Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove security policy violation binary artifacts #933

Closed
wants to merge 1 commit into from
Closed

Remove security policy violation binary artifacts #933

wants to merge 1 commit into from

Conversation

roger2hk
Copy link
Contributor

@roger2hk roger2hk commented May 23, 2022 •
edited
Loading

Fixes #910

WIP

  • Remove prometheus binary artifacts from repo
  • Pull from go get or git pull to generate?

Checklist

@roger2hk roger2hk changed the title Remove prometheus binary artifacts Remove security policy violation binary artifacts May 23, 2022
mhutchinson
mhutchinson reviewed May 23, 2022
View reviewed changes
Copy link
Contributor

@mhutchinson mhutchinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't binary files. It's a false positive.

@roger2hk
Copy link
Contributor Author

Thanks Martin for the information. This PR is now closed.

@roger2hk roger2hk closed this May 23, 2022
@roger2hk roger2hk deleted the fix-binary-artifacts-violation branch May 23, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhutchinson mhutchinson mhutchinson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Security Policy violation Binary Artifacts
2 participants
@roger2hk @mhutchinson