Variable and nested rule limits #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l46kok
reviewed
Jul 30, 2024
l46kok
approved these changes
Jul 30, 2024
TristonianJones
force-pushed
the
recursion-limits
branch
from
026d812
to
4601c9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a configurable limit for variable and nested rules
Ensure that policies are no so expressive that they cause problems
for stacks with limited recursion depths. The limit defaults to 100.
This change also makes a critical fix to support conditionally nested
rules. Previously the condition was being omitted during composition.
Closes #972