Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gcc warning about shadowing base class virtual overload. #1050

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Fix gcc warning about shadowing base class virtual overload. #1050

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions eval/public/containers/internal_field_backed_map_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ class FieldBackedMapImpl : public CelMap {

absl::StatusOr<const CelList*> ListKeys() const override;

// Include base class definitions to avoid GCC warnings about hidden virtual
// overloads.
using CelMap::ListKeys;

protected:
// These methods are exposed as protected methods for testing purposes since
// whether one or the other is used depends on build time flags, but each
Expand Down