Update rules_rust and rules_foreign_cc to latest #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
approved these changes
Nov 15, 2021
djmarcin
commented
Nov 15, 2021
| @@ -38,8 +38,8 @@ configure_make( | |||
| }), | |||
| lib_source = ":all_srcs", | |||
| out_static_libs = [ | |||
There was a problem hiding this comment.
The ordering here is apparently significant. Without reordering, rust linking fails because ld is a single pass linker and the libraries need to be linked in order (ssl then crypto). I'm not sure if that's an issue in some recent version of rules_rust or what since it appears that it was working in this other order previously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two repos have breaking changes in latest. This means that importing this repo in a
WORKSPACEfails if newer versions of rules_rust and/or rules_foreign_cc are already imported.