Bugfix: MachineInfo Clone() to also clone "SwapCapacity"

[iholder101]

This PR fixes a small bug in MachineInfo's Clone() method.

Today, SwapCapacity is not being cloned, therefore after cloning it is being set to 0.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[k8s-ci-robot]

Hi @iholder101. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Creatone]

/ok-to-test

[SergeyKanzhelev]

closing and reopening to recalculate CLA

[SergeyKanzhelev]

@iholder101 can you please sign CLA?

[SergeyKanzhelev]

Would you be OK writing a small unit test for the Clone method?

[iholder101]

@iholder101 can you please sign CLA?

Yes, I'm currently waiting for answers regarding what's the right way to do so.

Would you be OK writing a small unit test for the Clone method?

Of course! Will do soon

[iholder101]

Hey @SergeyKanzhelev!

I've added a unit test.
To ensure further fields won't be missed in the future, I've used reflection to fail the test if one or more fields aren't populated.

For example, if I avoid populating SwapCapacity in getFakeMachineInfo() function, the test fails with the following message:

=== RUN   TestMachineInfoClone
    machine_test.go:31: 
        	Error Trace:	cadvisor/info/v1/machine_test.go:31
        	Error:      	Should be false
        	Test:       	TestMachineInfoClone
        	Messages:   	field SwapCapacity is not populated
--- FAIL: TestMachineInfoClone (0.00s)

[SergeyKanzhelev]

/lgtm

[iholder101]

Hey @SergeyKanzhelev!

Thanks for the review and LGTM.
Would you mind pinging to an approver to have another look at this?

[dims]

/approve
/lgtm

[fabiand]

@dims can we consider an out-of-cycle (or pulled up) release of cadvisor in order to increase the chances for swap to land in Kube?
IOW we request an early release with this fix in order to make sure that we can line up all the work in Kube itself to get this work merged in time. Thanks

[fabiand]

cc @SergeyKanzhelev @dchen1107

[dims]

@fabiand i am supportive, @bobbypage is the one who does releases, so please check with him.

[fabiand]

Thanks @dims
@bobbypage please share your thoughts :)

[iholder101]

Thanks @dims @bobbypage please share your thoughts :)

Gentle ping. @bobbypage :)
The deadline for feature freeze (July 19th) comes fast, and this blocks my PR from getting in.

[bobbypage]

@Creatone helped to cut a new v0.47.3 release with the bug fix and kubernetes/kubernetes#119225 will bump the dependency. Thanks all!