Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: Rollback gopkg.in/yaml.v2 to v2.2.8 #2728

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

bobbypage
Copy link
Collaborator

Switch back to gopkg.in/[email protected]

go get gopkg.in/[email protected]

gopkg.in/[email protected] has a breaking change that is affecting being able to vendor cadvisor into k/k ref kubernetes/kubernetes#96425 (comment) and go-yaml/yaml#670

gopkg.in/[email protected] is a transitive dependency of github.com/prometheus/[email protected]. cadvisor moved to github.com/prometheus/[email protected] as part of #2716

Downgrade dependent modules (e.g. github.com/prometheus/common) for now to ensure we can stay on gopkg.in/[email protected].

@google-cla google-cla bot added the cla: yes label Nov 12, 2020
@bobbypage
Copy link
Collaborator Author

/cc @dims @dashpole

@bobbypage bobbypage force-pushed the vendor-rollback-yaml branch from 6a0c326 to f63546e Compare November 12, 2020 19:52
@dashpole
Copy link
Collaborator

can you link to where it was bumped in the first place?

@bobbypage
Copy link
Collaborator Author

bobbypage commented Nov 12, 2020

It's a transitive dependency of github.com/prometheus/common.

#2716 bumped github.com/prometheus/[email protected] to github.com/prometheus/[email protected] in cadvisor.

In turn the bump of gopkg.in/[email protected] in github.com/prometheus/common happened in prometheus/common#242

@bobbypage bobbypage merged commit 6118d8d into google:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants