Add missing export for HTMLProcessor in index.ts #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
tushuhei
reviewed
Oct 24, 2022
There was a problem hiding this comment.
Good catch! Thanks for your proposal. Please fix the JS styling issue and sign Google CLA to proceed.
javascript/src/index.ts
Outdated
| @@ -15,3 +15,4 @@ | |||
| */ | |||
|
|
|||
| export * from './parser.js'; | |||
| export {HTMLProcessor} from "./html_processor.js"; | |||
Harukaichii
force-pushed
the
js-add-html-processor-to-export
branch
from
2d37009
to
b55e835
Compare
fix lint styling issues
Harukaichii
force-pushed
the
js-add-html-processor-to-export
branch
from
b55e835
to
523e5d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I was experimenting with the library and wanted to do something with the HTMLProcessor as described
here
However, it would not let me import and I believe it's because there is a missing export statement from
index.ts.Hence I added an extra line in.