Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when the display property is empty #76

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Conversation

kojiishi
Copy link
Collaborator

This patch supports when the display property is empty.

This occurs when the element is not connected. In that case,
HTMLProcessor uses its built-in rules to determine whether the
element is inline or block.

Fixes #74.

This patch supports when the `display` property is empty.

This occurs when the element is not [connected]. In that case,
`HTMLProcessor` uses its built-in rules to determine whether the
element is inline or block.

[connected]: https://dom.spec.whatwg.org/#connected
@kojiishi kojiishi requested a review from tushuhei July 15, 2022 05:02
@kojiishi
Copy link
Collaborator Author

@tushuhei PTAL.

Copy link
Member

@tushuhei tushuhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

@tushuhei tushuhei merged commit 7e5a211 into google:main Jul 18, 2022
@kojiishi kojiishi deleted the display branch July 19, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion failed at computing styles of elements.
2 participants