Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve typing #426

Merged
merged 6 commits into from
Dec 20, 2023
Merged

Improve typing #426

merged 6 commits into from
Dec 20, 2023

Commits on Dec 19, 2023

  1. Specify model type and mark it private and readonly.

    @amitmarkel
    amitmarkel committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    1043b9f View commit details
    Browse the repository at this point in the history

  2. Move the baseScope variable that is a constant to be class-level and … 

    …readonly.
    @amitmarkel
    amitmarkel committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    228e297 View commit details
    Browse the repository at this point in the history

  3. Bail-out earlier on the score summation loop to improve performance.

    @amitmarkel
    amitmarkel committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    9305a53 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Merge branch 'google:main' into improve

    @amitmarkel
    amitmarkel authored Dec 20, 2023
    Configuration menu
    Copy the full SHA
    25d73db View commit details
    Browse the repository at this point in the history

  2. Revert "Bail-out earlier on the score summation loop to improve perfo… 

    …rmance."

This reverts commit 9305a53.
    @amitmarkel
    amitmarkel committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    ca6501b View commit details
    Browse the repository at this point in the history

  3. Add comment that score items in models may be negative.

    @amitmarkel
    amitmarkel committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    6e0f63e View commit details
    Browse the repository at this point in the history