Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take split_dataset out from fit #42

Merged
merged 2 commits into from
Mar 28, 2022
Merged

Take split_dataset out from fit #42

merged 2 commits into from
Mar 28, 2022

Conversation

tushuhei
Copy link
Member

@tushuhei tushuhei commented Jan 28, 2022 •
edited
Loading

Take out the split_dataset call from the fit function to remove randomness from that, which will make the tests more reliable.

@tushuhei
Take split_dataset out from fit
c824d80 
Change-Id: Ifc92c4c82208117b760f70f8b179e58cee9e4d3f
@tushuhei
Edit flake8 rule to ignore closing bracket indentation
c413bfe 
Change-Id: Icc45432c18b8671751817c58c2e12f615560eb41
@tushuhei
Copy link
Member Author

@miuraken Hello! Could you review this PR when you have time?

kojiishi
kojiishi approved these changes Mar 27, 2022
View reviewed changes
Copy link
Collaborator

@kojiishi kojiishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rs-lgtm

@tushuhei tushuhei merged commit 5172e0a into main Mar 28, 2022
@tushuhei tushuhei deleted the no-random-fit branch December 14, 2022 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kojiishi kojiishi kojiishi approved these changes

@miuraken miuraken miuraken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tushuhei @miuraken @kojiishi