[java] Fix errors by collapsed white spaces and <br>
#367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kojiishi
force-pushed
the
gettext
branch
2 times, most recently
from
2a2d782
to
adfeffa
Compare
|
PTAL. |
This patch fixes `HTMLProcessor` raising exceptions for: 1. When the source has collapsible spaces (i.e., consecutive spaces, or leading/trailing spaces.) 2. When the source has `<br>` elements. The jsoup `Element.text()` collapses white spaces. This is fixed by replacing it with []`whoteText()`](https://jsoup.org/apidocs/org/jsoup/nodes/Element.html#wholeText()) which doesn't normalize spaces. It also returns `\n` for `<br>` element. This is fixed by incrementing `scanIndex` for `<br>`. Fixes google#366.
kojiishi
added a commit
to kojiishi/budoux
that referenced
this pull request
Nov 15, 2023
This patch replaces `wholeText()` implemented in google#367 by a subclass of `NodeVisitor`. Whether the `wholeText()` emits `\n` for `<br>` depends on the jsoup versions. To ensure that `getText()` always matches what `resolve()` does, this patch changes to its own logic.
kojiishi
added a commit
to kojiishi/budoux
that referenced
this pull request
Nov 15, 2023
This patch replaces `wholeText()` implemented in google#367 by a subclass of `NodeVisitor`. Whether the `wholeText()` emits `\n` for `<br>` depends on the jsoup versions. To ensure that `getText()` always matches what `resolve()` does, this patch changes to its own logic.
kojiishi
added a commit
to kojiishi/budoux
that referenced
this pull request
Nov 15, 2023
This patch replaces `wholeText()` implemented in google#367 by a subclass of `NodeVisitor`. Whether the `wholeText()` emits `\n` for `<br>` depends on the jsoup versions. To ensure that `getText()` always matches what `resolve()` does, this patch changes to its own logic.
kojiishi
added a commit
to kojiishi/budoux
that referenced
this pull request
Nov 15, 2023
This patch replaces `wholeText()` implemented in google#367 by a subclass of `NodeVisitor`. Whether the `wholeText()` emits `\n` for `<br>` depends on the jsoup versions. To ensure that `getText()` always matches what `resolve()` does, this patch changes to its own logic.
kojiishi
added a commit
to kojiishi/budoux
that referenced
this pull request
Nov 15, 2023
This patch replaces `wholeText()` implemented in google#367 by a subclass of `NodeVisitor`. Whether the `wholeText()` emits `\n` for `<br>` depends on the jsoup versions. To ensure that `getText()` always matches what `resolve()` does, this patch changes to its own logic.
kojiishi
added a commit
to kojiishi/budoux
that referenced
this pull request
Nov 15, 2023
This patch replaces `wholeText()` implemented in google#367 by a subclass of `NodeVisitor`. Whether the `wholeText()` emits `\n` for `<br>` depends on the jsoup versions. To ensure that `getText()` always matches what `resolve()` does, this patch changes to its own logic.
tushuhei
pushed a commit
that referenced
this pull request
Nov 15, 2023
This patch replaces `wholeText()` implemented in #367 by a subclass of `NodeVisitor`. Whether the `wholeText()` emits `\n` for `<br>` depends on the jsoup versions. To ensure that `getText()` always matches what `resolve()` does, this patch changes to its own logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes
HTMLProcessorraising exceptions for:<br>elements.The jsoup
Element.text()collapses white spaces. This is fixed by replacing it withwhoteText()which doesn't normalize spaces.Also, they return
\nfor<br>element. This is fixed by incrementingscanIndexfor<br>.Fixes #366.