Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Universal unit testing #125

Merged
merged 11 commits into from
Mar 16, 2023
Merged

Universal unit testing #125

merged 11 commits into from
Mar 16, 2023

Conversation

tushuhei
Copy link
Member

  • Run unit tests both in browser (Karma) and Node.js
  • Gather risky functions that interact with elements in dom.ts(e.g. setInnerHtml)
  • Replace the getComputedStyle mock with new JSDOM().window.getComputedStyle

@tushuhei
Separate window by environment
c45de93 
Change-Id: I5cc66b20abc58b2a772e8c1674c2a4de0318730e
@tushuhei
Add Karma
6a946bc 
Change-Id: I28fd7f1fa53cd175e3550fd9811aecca3e707841
@tushuhei
Rename Web Components build rules
0230106 
Change-Id: I1534dd7d00661e9974bb82f9d0b86eac925d1d67
@tushuhei
Separate test files by environment
263ee85 
Change-Id: Ieae696ad04618534a3156efff2b543b9c81b609e
@tushuhei
Update unit tests for universal JS
0406da7 
Change-Id: I1f0444263f5bf7d15ac7237efa456d6f85fe9cd2
@tushuhei
Add override modifier
e708233 
Change-Id: I488c10d9ef167a4cd1c12bda1a46a1dbe2aaca76
@tushuhei
Collect innerHTML setters in one place
6bbf785 
Change-Id: I831be28d277f23f83f7807195a56ec0fd1050bdb
@tushuhei
Collects style updates to one place
83ea126 
Change-Id: Iba157a211028d62821d2ad9eb97404363e0eb3e5
@tushuhei
Add some comments
823a954 
Change-Id: Iefb94f8508db342c16fcfa62e820e2315e596b6e
@tushuhei
Add a license header to karma.conf.js
a38c6db 
Change-Id: I3e1ec6595d9e3511b29d9a00c79df30fdaa2ed4e
@tushuhei tushuhei requested a review from kojiishi March 15, 2023 02:31
kojiishi
kojiishi approved these changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@kojiishi kojiishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, awesome!

@tushuhei tushuhei merged commit 42ec92c into main Mar 16, 2023
@tushuhei tushuhei deleted the universal-testing2 branch December 12, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kojiishi kojiishi kojiishi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tushuhei @kojiishi