chore(generators): Fix nits #7166
Merged
+16
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses various nits that escaped previous PRs: * Add TSDoc for `BlockGenerator` in `core/generator.ts` for PR google#7150. * Fix bad formating in `generators/javascript.js` from PR google#7153. * Add missing `@enum` tag that should have been included in PR google#7160. * Delete obsolete comment from `generators/python.js` for PR google#7163.
github-actions
bot
removed
the
PR: chore
github-actions
bot
added
PR: chore
maribethb
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Addresses various nits that escaped previous PRs:
BlockGeneratorincore/generator.tsfor PR refactor(generators)!:CodeGeneratorper-block-type generator function dictionary #7150.generators/javascript.jsfrom PR refactor(generators): IntroduceJavascriptGeneratorclass,Orderenum #7153.@enumtag that should have been included in PR refactor(generators): IntroduceDartGeneratorclass,Orderenum #7160.generators/python.jsfor PR refactor(generators): IntroducePythonGeneratorclass,Orderenum #7163.Fixes #7085.