Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return annotations #7118

Merged
merged 5 commits into from
May 24, 2023
Merged

fix: return annotations #7118

merged 5 commits into from
May 24, 2023

Conversation

BeksOmega
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Fixes N/A

Proposed Changes

Reenables tag linting so that we don't commit @return annotations.

Test Coverage

N/A

Documentation

N/A

Additional Information

Assigning christopher so he can check if removing the @suppress or @nocollapse tags breaks anything.

@BeksOmega BeksOmega requested a review from cpcallen May 24, 2023 18:03
@BeksOmega BeksOmega requested a review from a team as a code owner May 24, 2023 18:03
@github-actions github-actions bot added the PR: fix Fixes a bug label May 24, 2023
Copy link
Contributor

@maribethb maribethb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the advanced compilation test and everything worked without @suppress

also you can use @file instead of @fileoverview but the comments you removed aren't adding anything of value so that's fine

@BeksOmega BeksOmega merged commit 42b8c6e into google:develop May 24, 2023
@BeksOmega BeksOmega deleted the fix/returns branch May 14, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants