Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove deprecated functionality for v10. #6862

Closed
wants to merge 3 commits into from
Closed

chore: Remove deprecated functionality for v10. #6862

wants to merge 3 commits into from

Conversation

gonfunko
Copy link
Contributor

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Fixes #6814

Proposed Changes

This PR removes deprecated methods/classes/files that were slated for removal in v10.

@gonfunko gonfunko requested a review from a team as a code owner February 24, 2023 20:52
@gonfunko gonfunko requested a review from cpcallen February 24, 2023 20:52
@github-actions github-actions bot added the PR: chore General chores (dependencies, typos, etc) label Feb 24, 2023
cpcallen
cpcallen approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@cpcallen cpcallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but: might it be advisable to mark this as draft until we decide we're going to release v10?

core/events/workspace_events.ts Outdated Show resolved Hide resolved
@gonfunko gonfunko added the breaking change Used to mark a PR or issue that changes our public APIs. label Feb 27, 2023
@gonfunko gonfunko marked this pull request as draft February 27, 2023 16:08
@rachel-fenichel rachel-fenichel mentioned this pull request May 11, 2023
Merged
4 tasks
@rachel-fenichel
Copy link
Collaborator

Superseded by #7077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcallen cpcallen cpcallen approved these changes

Assignees

@cpcallen cpcallen

Labels
breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation warning removal for v10
3 participants
@gonfunko @rachel-fenichel @cpcallen