Some goog.dom removal #1991
Merged
Some goog.dom removal #1991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnmAtAnm
approved these changes
Aug 1, 2018
| @@ -54,7 +53,7 @@ Blockly.inject = function(container, opt_options) { | |||
| document.querySelector(container); | |||
| } | |||
| // Verify that the container is in document. | |||
| if (!goog.dom.contains(document, container)) { | |||
| if (!Blockly.utils.containsNode(document, container)) { | |||
There was a problem hiding this comment.
container is an unfortunate variable name for the second parameter, given the container actually tested is document.
Merged
NeilFraser
added a commit
that referenced
this pull request
Apr 16, 2023
The 'compareDocumentPosition' call was inherited from Closure Library, in order to work with IE 8 and earlier. Use the more modern 'contains' call instead. This change was originally added here: #1991 Remove the DOCUMENT_POSITION_CONTAINED_BY constant which is not a NodeType and should never have been part of that enum. This change was originally added here: #2736
NeilFraser
added a commit
that referenced
this pull request
Apr 17, 2023
The 'compareDocumentPosition' call was inherited from Closure Library, in order to work with IE 8 and earlier. Use the more modern 'contains' call instead. This change was originally added here: #1991 Remove the DOCUMENT_POSITION_CONTAINED_BY constant which is not a NodeType and should never have been part of that enum. This change was originally added here: #2736
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small step for deleting Closure.