third_party: update googletest to current main #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build still appears broken. |
|
This failure seems different from the previous one(s). I think that there is a missing dependency somewhere. |
compnerd
force-pushed
the
gtest
branch
3 times, most recently
from
a4998d5 to
ad25037
Compare
Update the pinned revision for googletest to pick up google/googletest#2815 which should allow us to repair the macOS builds. Add dependency tracking to try to avoid a build race with capstone and libbloaty.
compnerd
force-pushed
the
gtest
branch
3 times, most recently
from
2f977cf to
ac8742f
Compare
The GHA agents have installed capstone via brew. Unfortunately, the pkg-config data for the bottle provides an include path with an extra component which we cannot reliably strip in the build system. The result is that `capstone/capstone.h` is not found. Explicitly inject an additional header search path from the command line to resolve the header properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the pinned revision for googletest to pick up google/googletest#2815 which should allow us to repair the macOS builds.