Add an option to filter on label names #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a `source-filter` option which allows a regex to be provided to filter the names of keys in data sources. When provided, only keys matching the pattern will be counted as part of the reported size. The option can be set via config files or the command line.
haberman
reviewed
Nov 11, 2019
src/bloaty.cc
Outdated
|
|
||
| uint64_t filtered = 0; | ||
| if (ShowFile(options)) { | ||
| filtered += toplevel_row_.filtered_filesize; |
There was a problem hiding this comment.
I don't think adding the two together is the right approach. Your existing format is good for the case that we're showing only VM or file:
Filtering enabled (source_filter); omitted 15.1Mi of entries
For the case that both VM and file are shown lets do this instead:
Filtering enabled (source_filter); omitted file=12.5Mi, vm=1.2Mi of entries
There was a problem hiding this comment.
That makes sense, updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a
source-filteroption which allows a regex to beprovided to filter the names of keys in data sources. When provided,
only keys matching the pattern will be counted as part of the reported
size. The option can be set via config files or the command line.