-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change C++ standard to C++17. #277
Conversation
So some additional context on the C++ standard version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me, since c++20
is causing more issues than it brings benefits for now.
(I largely prefer this to local patches here and there to be c++17 compliant).
0265353
to
b3bcce7
Compare
Can you add a line to main README.md that says something along the lines of C++17 compliant compiler? Maybe a bullet point under the Requirements? |
C++20 is not well support with all our compilation environments.
Added to both
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
C++20 is not well support with all our compilation environments.