Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change C++ standard to C++17. #277

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Change C++ standard to C++17. #277

merged 1 commit into from
Aug 25, 2023

Conversation

hysw
Copy link
Collaborator

@hysw hysw commented Aug 22, 2023

C++20 is not well support with all our compilation environments.

@hysw
Copy link
Collaborator Author

hysw commented Aug 22, 2023

So some additional context on the C++ standard version:

Copy link
Member

@Keenuts Keenuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me, since c++20 is causing more issues than it brings benefits for now.
(I largely prefer this to local patches here and there to be c++17 compliant).

@hysw hysw force-pushed the tianc/cpp17 branch 2 times, most recently from 0265353 to b3bcce7 Compare August 24, 2023 18:59
@chaoticbob
Copy link
Contributor

Can you add a line to main README.md that says something along the lines of C++17 compliant compiler? Maybe a bullet point under the Requirements?

C++20 is not well support with all our compilation environments.
@hysw
Copy link
Collaborator Author

hysw commented Aug 24, 2023

Can you add a line to main README.md that says something along the lines of C++17 compliant compiler? Maybe a bullet point under the Requirements?

Added to both README.md and CONTRIBUTING.md

  • README.md Linux requirement: clang 10 is our presubmit, and gcc 9 is fully C++17 compliant
  • README.md MSVC 2019 can compile up to C++20, so it's a higher requirement than a C++17 compliant compiler
  • CONTRIBUTING.md since that's where submission requirement is listed

Copy link
Contributor

@chaoticbob chaoticbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apazylbe apazylbe merged commit 85436e5 into google:main Aug 25, 2023
5 checks passed
@hysw hysw mentioned this pull request Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants