Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable windows-latest tests for newer Bazel #1641

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

nicholasjng
Copy link
Contributor

The Windows toolchain detection fix made it into Bazel 6.3.0 (bazelbuild/bazel#18960), so the CI should work again with the re-enabled windows-latest marker if Bazel 6.3.0 is already installed in the newest windows-latest image.

Also, require Bazel 6.3.0 in the Linux container setup in cibuildwheel, and bump cibuildwheel to v2.14.1 (July 2023) in anticipation of building Python 3.12 wheels (SABI builds with nanobind!).

The Windows toolchain detection fix made it into Bazel 6.3.0, so the CI
should work again with the re-enabled `windows-latest` marker.

Require Bazel 6.3.0 in the Linux container setup in `cibuildwheel`.
@dmah42
Copy link
Member

dmah42 commented Jul 31, 2023

fantastic. thank you.

@dmah42 dmah42 merged commit 8f7b8dd into google:main Jul 31, 2023
@nicholasjng nicholasjng deleted the new-bazel branch July 31, 2023 09:53
@nicholasjng
Copy link
Contributor Author

always a pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants