Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default usage of reserved register #78

Closed
3 tasks done
appujee opened this issue Mar 17, 2023 · 7 comments
Closed
3 tasks done

Fix default usage of reserved register #78

appujee opened this issue Mar 17, 2023 · 7 comments
Labels

Comments

@appujee
Copy link
Collaborator

appujee commented Mar 17, 2023

First, X27 X3 needs to be reserved. This is blocked on: https://reviews.llvm.org/D146463

@appujee appujee added the llvm label Mar 17, 2023
@enh-google
Copy link
Collaborator

not this one :-)

lib/hwasan/hwasan_setjmp_riscv64.S:  fsd   fs11, 25<<3(x10)

remember that we'll need to update bionic and ART if we make this change too.

(is libffi affected?)

@appujee
Copy link
Collaborator Author

appujee commented Mar 17, 2023

not this one :-) lib/hwasan/hwasan_setjmp_riscv64.S: fsd fs11, 25<<3(x10)

striked it out.

(is libffi affected?)

doesn't seem like it: https://github.com/libffi/libffi/blob/master/src/riscv/sysv.S

@enh-google
Copy link
Collaborator

striked it out.

seems to have affected the wrong one?

@MaoHan001
Copy link

What is S11/X27 reserved for? I haven't seen any related topics. I previously only saw that the software SCS requires the use of S2/X18.

@appujee
Copy link
Collaborator Author

appujee commented Mar 22, 2023

it is for the SCS. Previously S2 was reserved but it didn't appear to be a good choice. Some discussion is here: riscv-non-isa/riscv-elf-psabi-doc#370

@enh-google
Copy link
Collaborator

enh-google commented May 1, 2023

@appujee --- given that this bug is marked as blocking #78 do we actually need the kernel work here? that seems orthogonal?

@appujee
Copy link
Collaborator Author

appujee commented May 2, 2023

makes sense. I've removed the item tracking kernel patches.

@appujee appujee closed this as completed May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants