Add flyover text as secondary dialog title #2648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FikriMilano
requested review from
aditya-07,
jingtang10,
MJ1998 and
santosh-pingle
as code owners
…ondary-dialog-title
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
Jul 30, 2024
- With unmerged PR #9 - WUP PR google#2178 - WUP google#2652 - WUP google#2521 - WUP google#2645 - WUP google#2648 - WUP google#2650
jingtang10
approved these changes
Aug 20, 2024
...in/java/com/google/android/fhir/datacapture/views/factories/DialogSelectViewHolderFactory.kt
Show resolved
Hide resolved
…ondary-dialog-title
ndegwamartin
pushed a commit
to opensrp/android-fhir
that referenced
this pull request
Sep 10, 2024
* Add flyover text as secondary dialog title * spotless * Add doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2647
Description
If item.text is null, get the dialog title from flyover text
Alternative(s) considered
N/A
Type
Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.