Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise compile sdk level to 34 #2633

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

jingtang10
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Description
Raise compile sdk level to 34

Alternative(s) considered
NA

Type
Builds

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Copy link
Collaborator

@aditya-07 aditya-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jingtang10
Copy link
Collaborator Author

getting the following error

RunTests


Incompatible model, 'panther', and version, '34'
Supported version ids for 'panther': 33
Total run duration: 0m  2s

> Task :engine:benchmark:execFlank FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':engine:benchmark:execFlank'.
> Process 'command '/usr/lib/jvm/java-17-openjdk-amd64/bin/java'' finished with non-zero exit value 18

* Try:
> Run with --info or --debug option to get more log output.
> Get more help at [https://help.gradle.org](https://www.google.com/url?q=https://help.gradle.org&sa=D).

@jingtang10
Copy link
Collaborator Author

updated pr to see if using a different model that supports api level 24 on firebase would fix this. thx @omarismail94

@jingtang10
Copy link
Collaborator Author

jingtang10 commented Jul 24, 2024

seeing a whole bunch of these errors

Screenshot 2024-07-24 at 14 41 55

I think it's caused by the test apk for the instrumentation tests being targetted at a lower version. so on the emulator there is this warning dialog that pops up for each test. we could try to click away the dialog in the test. but i'm going to try to raise that in the test options block of the data capture library and see if that works.

@jingtang10 jingtang10 requested a review from a team as a code owner September 3, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: PR under Review
Development

Successfully merging this pull request may close these issues.

3 participants