Skip to content
This repository has been archived by the owner on Feb 9, 2023. It is now read-only.

Run check_audio in python env #285

Closed
wants to merge 1 commit into from
Closed

Conversation

mosch
Copy link

@mosch mosch commented Feb 15, 2018

The documented command is missing the env and this is what happend:

Traceback (most recent call last):
  File "checkpoints/check_audio.py", line 27, in <module>
    import aiy.audio  # noqa
ImportError: No module named 'aiy'

I changed it to the command that can be found in shortcuts/check_audio.desktop

The documented command is missing the env and this is what happend:  

```
Traceback (most recent call last):
  File "checkpoints/check_audio.py", line 27, in <module>
    import aiy.audio  # noqa
ImportError: No module named 'aiy'
```

I changed it to the command that can be found in `shortcuts/check_audio.desktop`
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@mosch
Copy link
Author

mosch commented Feb 15, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@drigz
Copy link
Member

drigz commented Feb 16, 2018

Hi @mosch, thanks for the pull request!

We've updated the documentation internally but it's not been released to the external branch yet. I've reopened #242 to make it clearer that this is a known issue and a fix is on the way.

@mosch
Copy link
Author

mosch commented Feb 17, 2018

Oh alright! Closing this. Just curious: Why do you separate external and internal? :-)

@mosch mosch closed this Feb 17, 2018
@drigz
Copy link
Member

drigz commented Feb 19, 2018

We separate the two repos so we can work on new kits and run hardware tests internally. There's a tradeoff as it takes longer for changes like this to get released, but we're trying to come up with a process that minimizes that.

@mosch mosch deleted the patch-1 branch February 20, 2018 14:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants