-
Notifications
You must be signed in to change notification settings - Fork 693
.asoundrc added to audio configuration #172
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
Looks like I may have found an answer but I have to check... https://developers.google.com/assistant/sdk/develop/grpc/hardware/audio
Going to check that config in a bit and I will post on here if that works. I already reformatted my SD card so it might take a bit. |
Oh nm is that what this does |
@jrgleason, the @shivasiddharth, does this PR fully fix the issue, or does whatever populates ~/.asoundrc also modify it? We found it that the volume widget would create/modify .asoundrc, and we tried to eliminate the situations where this happened (eg with alsa-init.service). |
@drigz , in the tests that i did, this seemed to fix the issue. However, just to double check, someone else might as well try this. |
What did you test? Do you know what caused .asoundrc to be created if not present? I can try to reproduce. |
I blanked the EEPROM, compiled I2S kernels just to make sure that it was not the HAT that was causing the issue. The volume widget issue i suppose is the case where the widget appears muted without controls ? I believe that to be the result of .asroundrc being auto populated. |
Thanks. I'm out of the office this week, but I'll try it out next week. |
I've tried to reproduce this but I can't. I would merge it, but I'm concerned about confusing users who edit one file, but the changes don't work because ALSA is reading the other file. Does it work if you use a symlink? ie Also, you should check that
|
|
That's a fair point, the script won't work fully until #95 is resolved.
I'm concerned about people who want to tweak the audio config, eg to work around #47.
That's a good idea, and maybe we'll have a chance to find out what people to do cause ~/.asoundrc to be created. #184 |
#187 makes this unnecessary. |
This was originally proposed by @shivasiddharth in #172. We managed to figure out what made it necessary in that case, but since the problem has come back with the aiyprojects-2018-01-03 image, I think the workaround will be more reliable long term. This should avoid issues like #254 and #262. Change-Id: I50feb4e012ba7c1e47dbf6ab9dd88661895decfc
The normal audio installation will blank the .asoundrc and just copy the asound.conf. The Raspbian Stretch tends to populate its own .asoundrc, if left empty and it will cause audio rate errors like this one googlesamples/assistant-sdk-python#127
So its advisable to copy .asoundrc as well along with asound.conf.