Skip to content
This repository has been archived by the owner on Feb 9, 2023. It is now read-only.

Narrow check for state change in led driver #167

Merged
merged 1 commit into from
Nov 28, 2017

Conversation

jthomaschewski
Copy link
Contributor

As state is checked with if state, the valid state change to 0 (LED_OFF) is ignored by the driver.
As a result its not possible to use the LED_OFF state in the _state_map of _status_ui.py.

Some people would like to turn of the constant flashing of the LED in ready state (DARK_BEACON) (#2, #15). This changes makes this as easy as changing the ready state in the state_map.

Fixes use of "LED.OFF" state in status_ui state map
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@jthomaschewski
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Nov 6, 2017
@drigz drigz requested a review from ensonic November 7, 2017 08:58
@OlivierBondu
Copy link

I would also be interested to have this merged 😄 is there any reason not to ?

@ensonic ensonic merged commit 7377006 into google:voicekit Nov 28, 2017
@OlivierBondu
Copy link

thanks!

drigz added a commit to drigz/aiyprojects-raspbian that referenced this pull request Dec 21, 2017
Summary of changes:
- Fix instructions for using the Voice Kit on Stretch (google#187)
- Make it easier to turn the LED off (google#167)
- Fix crash with trigger sound (google#163)
- Let user code control TTS (google#185)
- Enable hotwording with Cloud Speech (0b4972b)
drigz added a commit to drigz/aiyprojects-raspbian that referenced this pull request Jan 3, 2018
Summary of changes:
- Fix instructions for using the Voice Kit on Stretch (google#187)
- Make it easier to turn the LED off (google#167)
- Fix crash with trigger sound (google#163)
- Let user code control TTS (google#185)
- Enable hotwording with Cloud Speech (0b4972b)

Change-Id: Icfad0fadeaeb63417413c598763eceddb5bd0b9c
drigz added a commit to drigz/aiyprojects-raspbian that referenced this pull request Jan 3, 2018
Summary of changes:
- Fix instructions for using the Voice Kit on Stretch (google#187)
- Make it easier to turn the LED off (google#167)
- Fix crash with trigger sound (google#163)
- Let user code control TTS (google#185)
- Enable hotwording with Cloud Speech (0b4972b)
- Update to Cloud Speech v1 (google#206)
drigz added a commit to drigz/aiyprojects-raspbian that referenced this pull request Jan 3, 2018
Summary of changes:
- Fix instructions for using the Voice Kit on Stretch (google#187)
- Make it easier to turn the LED off (google#167)
- Fix crash with trigger sound (google#163)
- Let user code control TTS (google#185)
- Enable hotwording with Cloud Speech (0b4972b)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants