This repository has been archived by the owner on Feb 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 693
Narrow check for state change in led driver #167
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes use of "LED.OFF" state in status_ui state map
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
I would also be interested to have this merged 😄 is there any reason not to ? |
ensonic
approved these changes
Nov 28, 2017
thanks! |
drigz
added a commit
to drigz/aiyprojects-raspbian
that referenced
this pull request
Dec 21, 2017
Summary of changes: - Fix instructions for using the Voice Kit on Stretch (google#187) - Make it easier to turn the LED off (google#167) - Fix crash with trigger sound (google#163) - Let user code control TTS (google#185) - Enable hotwording with Cloud Speech (0b4972b)
drigz
added a commit
to drigz/aiyprojects-raspbian
that referenced
this pull request
Jan 3, 2018
Summary of changes: - Fix instructions for using the Voice Kit on Stretch (google#187) - Make it easier to turn the LED off (google#167) - Fix crash with trigger sound (google#163) - Let user code control TTS (google#185) - Enable hotwording with Cloud Speech (0b4972b) Change-Id: Icfad0fadeaeb63417413c598763eceddb5bd0b9c
drigz
added a commit
to drigz/aiyprojects-raspbian
that referenced
this pull request
Jan 3, 2018
Summary of changes: - Fix instructions for using the Voice Kit on Stretch (google#187) - Make it easier to turn the LED off (google#167) - Fix crash with trigger sound (google#163) - Let user code control TTS (google#185) - Enable hotwording with Cloud Speech (0b4972b) - Update to Cloud Speech v1 (google#206)
drigz
added a commit
to drigz/aiyprojects-raspbian
that referenced
this pull request
Jan 3, 2018
Summary of changes: - Fix instructions for using the Voice Kit on Stretch (google#187) - Make it easier to turn the LED off (google#167) - Fix crash with trigger sound (google#163) - Let user code control TTS (google#185) - Enable hotwording with Cloud Speech (0b4972b)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
state
is checked withif state
, the valid state change to0
(LED_OFF) is ignored by the driver.As a result its not possible to use the LED_OFF state in the
_state_map
of_status_ui.py
.Some people would like to turn of the constant flashing of the LED in ready state (
DARK_BEACON
) (#2, #15). This changes makes this as easy as changing the ready state in the state_map.