Skip to content
This repository has been archived by the owner on Feb 9, 2023. It is now read-only.

voicekit branch still uses hard coded home directory #139

Closed
mpember opened this issue Sep 28, 2017 · 2 comments
Closed

voicekit branch still uses hard coded home directory #139

mpember opened this issue Sep 28, 2017 · 2 comments

Comments

@mpember
Copy link

mpember commented Sep 28, 2017 •
edited
Loading

While most of the code has been updated to support a home directory other than "/home/pi", src/aiy/_apis/_speech.py still uses a hard-coded path when looking for the cloud_speech.json file.

Is there a reason this was kept?
@mpember mpember mentioned this issue Oct 14, 2017
Closed
drigz added a commit to drigz/aiyprojects-raspbian that referenced this issue Oct 18, 2017
@drigz
Don't hardcode home directory
810bb03 
Fixes google#139.
@drigz drigz mentioned this issue Oct 18, 2017
Merged
drigz added a commit that referenced this issue Oct 18, 2017
@drigz
Don't hardcode home directory (#156)
b47767e 
Fixes #139.
@mpember
Copy link
Author

mpember commented Oct 19, 2017

@drigz does the change intentionally remove support for the legacy file location?

@drigz
Copy link
Member

drigz commented Oct 19, 2017

Intentionally - that was only printed in the first run of magazines, so new users won't be using it.

If I'm wrong and people are using it, I'm happy to readd the legacy support.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drigz @mpember