Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several bugs in counter panel. #79

Merged
merged 3 commits into from
Feb 24, 2020
Merged

Fix several bugs in counter panel. #79

merged 3 commits into from
Feb 24, 2020

Conversation

stellama0208
Copy link
Contributor

lpy
lpy approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@lpy lpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on my side

@stellama0208
Identify a counter selection by counter id.
1407613 
 - Rather than the combinition of name and start time ts.
 - It will avoid losing track of the selection when quantization do some
 approximations on the time.
 - Bug 1: http://b/147922469, google#5.
 - Bug 2: http://b/149959272, google#2.
@stellama0208
Allow selecting counter under time quantization.
56ea342 
 - Bug: http://b/149959272. #1.
@stellama0208
Copy link
Contributor Author

Addressed the comments above. PTAL!

Another change in the updated PR is that now I query counter selection based on id rather than time range, this will further solve another bug that you couldn't select counter when zoomed too out in a long trace.

silence-do-good
silence-do-good approved these changes Feb 22, 2020
View reviewed changes
Copy link
Contributor

@silence-do-good silence-do-good left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit. Please check that.

gapic/src/main/com/google/gapid/perfetto/models/CounterTrack.java Outdated Show resolved Hide resolved
@stellama0208 stellama0208 merged commit 2a1e545 into google:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silence-do-good silence-do-good silence-do-good approved these changes

@rschiu rschiu rschiu approved these changes

@lpy lpy lpy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stellama0208 @lpy @rschiu @silence-do-good