Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flow layouts] RTL support #1073

Closed
brudaswen opened this issue Mar 9, 2022 · 1 comment
Closed

[Flow layouts] RTL support #1073

brudaswen opened this issue Mar 9, 2022 · 1 comment
Labels
stale Stale issues which are marked for closure

Comments

@brudaswen
Copy link

Description
Adding RTL support to FlowRow would allow to use this component to right align multiple components (e.g. buttons) and overflow them correctly into the correct order in case there is not enough space available -- but still showing the first button at the top.

Expected behavior
The following components in an RTL layout

| ... space ... | 3 | 2 | 1 |

should overflow into

| ... space ... | 1 |
| ... space ... | 2 |
| ... space ... | 3 |

PR incoming
I will create a PR for this, soon.

Additional context
Allows to align buttons according to the Material Dialog Specification:
image
brudaswen pushed a commit to brudaswen/accompanist that referenced this issue Mar 9, 2022
Add RTL support to Flow Layouts
0c0a6ce 
Fixes google#1073
@brudaswen brudaswen mentioned this issue Mar 9, 2022
Closed
brudaswen pushed a commit to brudaswen/accompanist that referenced this issue Mar 9, 2022
Add RTL support to Flow Layouts
582feb4 
Fixes google#1073
@github-actions
Copy link

github-actions bot commented Apr 9, 2022

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale Stale issues which are marked for closure label Apr 9, 2022
mtotschnig pushed a commit to mtotschnig/accompanist that referenced this issue Dec 5, 2022
@mtotschnig
Add RTL support to Flow Layouts
99de3a9 
Fixes google#1073
@mtotschnig mtotschnig mentioned this issue Dec 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale Stale issues which are marked for closure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Flow layout] Add RTL support to Flow Layouts brudaswen/accompanist
1 participant
@brudaswen