xRaddextexp - replaced yaml files with header table #7410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitheshsrikanth-mcw
force-pushed
the
xnn_raddextexp
branch
2 times, most recently
from
de662aa
to
e853c77
Compare
nitheshsrikanth-mcw
force-pushed
the
xnn_raddextexp
branch
7 times, most recently
from
2dfbc74
to
1e33a73
Compare
dsharletg
reviewed
Nov 6, 2024
tools/generate-raddextexp-test.py
Outdated
nitheshsrikanth-mcw
force-pushed
the
xnn_raddextexp
branch
from
212e426
to
d03ce4f
Compare
dsharlet
approved these changes
Nov 12, 2024
|
Update kernel declarations? |
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
-- e853c77 by nithesh <[email protected]>: Raddextexp - replaced yaml files with header table Replaced yaml files with header table for Raddextexp op -- 1e33a73 by nithesh <[email protected]>: Addressed review comments -- d03ce4f by nithesh <[email protected]>: Addressed review comments FUTURE_COPYBARA_INTEGRATE_REVIEW=#7410 from nitheshsrikanth-mcw:xnn_raddextexp 8af7373 PiperOrigin-RevId: 695826022
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
-- e853c77 by nithesh <[email protected]>: Raddextexp - replaced yaml files with header table Replaced yaml files with header table for Raddextexp op -- 1e33a73 by nithesh <[email protected]>: Addressed review comments -- d03ce4f by nithesh <[email protected]>: Addressed review comments FUTURE_COPYBARA_INTEGRATE_REVIEW=#7410 from nitheshsrikanth-mcw:xnn_raddextexp 8af7373 PiperOrigin-RevId: 695826022
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
-- e853c77 by nithesh <[email protected]>: Raddextexp - replaced yaml files with header table Replaced yaml files with header table for Raddextexp op -- 1e33a73 by nithesh <[email protected]>: Addressed review comments -- d03ce4f by nithesh <[email protected]>: Addressed review comments FUTURE_COPYBARA_INTEGRATE_REVIEW=#7410 from nitheshsrikanth-mcw:xnn_raddextexp 8af7373 PiperOrigin-RevId: 695826022
Replaced yaml files with header table for Raddextexp op
nitheshsrikanth-mcw
force-pushed
the
xnn_raddextexp
branch
from
8af7373
to
3388b56
Compare
nitheshsrikanth-mcw
force-pushed
the
xnn_raddextexp
branch
from
3388b56
to
b7c0f50
Compare
dsharletg
reviewed
Nov 21, 2024
| #define XNN_TEST_RADDEXTEXP_ELEMENT_DIV(ukernel, arch_flags, element_tile, ...) \ | ||
| TEST(ukernel, element_gt) \ | ||
| { \ | ||
| for (size_t element_size = element_tile * 2; element_size < element_tile * 10; element_size += element_tile) { \ |
There was a problem hiding this comment.
TEST_REQUIRES_ARCH_FLAGS(arch_flags)?
There was a problem hiding this comment.
Thanks for pointing out the missing TEST_REQUIRES_ARCH_FLAGS(arch_flags). The issue with the illegal instruction for AVX-512 has now been resolved and now the tests are passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.