HLS Support for Live Events #848

thasso · 2015-10-07T11:29:14Z

This pull requests adds support for HLS Live Event Streams where EXT-X-PLAYLIST-TYPE is set to EVENT and the player should allow seeking within the currently available range.

The seek range change is exposed through the EventListener and a delegation constructor was added so the only API change is the change of the EventListener interface.

(FYI Company Contributor Agreement should be on the way)

…events

thasso · 2015-10-22T14:19:37Z

@ojw28 Any feedback on this would be much appreciated. Do you you think this can be merged to dev? I think I could also add another commit that tackles #87 and support seeking in general live streams.

ojw28 · 2015-10-26T12:45:05Z

Hi. I'll get to this soon (sorry!).

pajatopmr · 2015-10-26T17:55:05Z

Would it be possible to add a sample to the HLS demo project that shows off this code? It is not clear if this PR fixes HLS live seeking. Does it?

ojw28 · 2015-10-26T18:43:30Z

Note that we have issues elsewhere saying "make the demo app simpler". So it's pretty unclear whether that's a good idea :)...

configure the seekbar

thasso · 2015-10-27T14:33:37Z

I added two commits to enable event support in the demo application. I think c64a1cf is okay, but I'm not so sure about 36f7f7e. Passing the listener information (the seek range info) into PlayerControl doesn't look very clean to me, but it might help to test this and I couldn't find a way to pass this information without more major changes.

For testing purposes, I only have a dummy stream at http://demo.castlabs.com/media/BBB-HLS/BBB-Event.m3u8 . It's an EVENT type stream that is not finished yet (no end tag), but please note that it does not update. Unfortunately I currently do not have access to a real live event stream.

pajatopmr · 2015-10-28T12:20:42Z

@thasso thanks for the testing information. I tried your BBB stream and an iTV24 live stream to test your code (from your repo) but get no joy. The player controls start and end time are both 0. Is there more that I need to do to test this PR?

Here's what I added to Samples.java:
new Sample("Live/DVR Fixed", "http://bcoveliveios-i.akamaihd.net/hls/live/215102/master_english/398/master.m3u8",
PlayerActivity.TYPE_HLS),
new Sample("Live/DVR Event", "http://demo.castlabs.com/media/BBB-HLS/BBB-Event.m3u8", PlayerActivity.TYPE_HLS),

thasso · 2015-10-28T13:45:26Z

@pajatopmr I have a hard time reproducing this for BBB. Here, the playback for BBB starts at 7:40 and the duration is displayed as 8:10 correctly (this is not a real event, so the duration will not change). There are not further changes required to make this work. Do you see output like availableRange [true, 0, 490000000] in the logs when you start playback?

For the iTV24 stream, this is expected behaviour for this PR. The stream playlists are not marked as "Event" so this PR has no effect and the player as well as the controls behave as before.

pajatopmr · 2015-10-28T14:15:45Z

@thasso I do see the available range in the logcat after correctly merging your change.

Should not a fixed size live window also report an available seek range change every
time a new "chunk" arrives? If yes, then your change should also apply to live.

thasso · 2015-10-29T10:37:23Z

@pajatopmr Can you please double check that you are using the correct branch to test this, or maybe add some logging statements in the HlsPlaylistParser to verify that the event tag is parsed correctly? If you do not see the range change log messages, something is wrong but I can not reproduce the issue. Here its working.

You might be right about the general range changes, but this PR was intended to add support for Events only, where the seeking window is clearly defined. But I agree that this could rather easily be extended to also send seek range change events for general live streams, which would put this more in the context of #87 and I'm not sure if that is a good idea for this PR ?!?

pajatopmr · 2015-10-29T13:38:24Z

@thasso Sorry about the confusion. Yes indeed, I did use the wrong branch initially but quickly realized and fixed my mistake to find your changes working as advertised. This PR thus provides me with the first ExoPlayer experience I have encountered where some Live behavior works from the player controls perspective, both from showing current time and duration as well as having seek behavior that works.

Now I would like to use your changes (in the lack of anything as good or better) to get Live working with a fixed size moving window as illustrated by the iTV24 stream I referenced above. Fwiw, the approach I am using is to generate an available range change event on top of this PR for every new chunk loaded.

pajatopmr · 2015-10-29T14:03:58Z

library/src/main/java/com/google/android/exoplayer/hls/HlsChunkSource.java

+    liveEvent |= mediaPlaylist.liveEvent;
+    durationUs = live || liveEvent ? C.UNKNOWN_TIME_US : mediaPlaylist.durationUs;
+
+    if(!live || liveEvent) {


Why is "live" being filtered out here. I would think that both a sliding fixed size live window and a growing sized live window (is this the same as an "Event" type?) would want to notify listeners about the available seek range change.

@ojw28 @thasso When I remove the conditional at line 630 and then test against the iTV24 live stream, it sort of works correctly. There is an excessive delay in forward seeking but backward seeking works fine. Can either of you make a suggestion where I can find and attempt to fix this seek bug. I have a hunch it is a known, existing issue.

ckarthikv · 2015-11-08T16:35:14Z

@pajatopmr - Needed the HLS live seeking feature in ExoPlayer, safe to cherry pick these 4 commits now?

pajatopmr · 2015-11-09T06:25:24Z

@ckarthikv No, it is not really safe to take these changes yet. The problem is that seeking forward still does not work correctly for the live stream mentioned in an earlier comment on this PR. There is an unacceptably long delay (sometimes measured in minutes) before playback continues from the desired seek position. I am currently working on solving this problem and will report any progress both here and in a separate issue.

ckarthikv · 2015-11-09T12:49:58Z

@pajatopmr - Thanks. My requirement is to get the HLS video to always start from the start of the LiveStream rather than the live-edge, which essentially means just one-time-backward-seeking to time 0L. Would these 4 commits help achieve the same?

thasso · 2015-11-09T13:52:42Z

@ckarthikv The PR as it is right now will not help with that as it only adds support for "Live Event" streams, not for general live streams and seeking support general live streams. I have another patch locally to enable that, but I am waiting for some feedback from @ojw28 in the PR first, before making it more complicated and tackle multiple problems at the same time.

ckarthikv · 2015-11-09T14:31:23Z

@thasso - Is there any way I could access the patch implemented locally? Would be of great help.

pajatopmr · 2015-11-09T14:31:33Z

@thasso @ckarthikv If I read the HLS spec correctly (which matches some comments I have read by @ojw28) seeking to 0 should cause a seek to the live edge. This PR handles the seek to live edge for EVENT type accordingly. Seek to the live edge via 0L does not work for live (no EVENT playlist type) but I am working on making this change. @thasso if you have a fix for this I would love to see it.

thasso · 2015-11-09T14:40:23Z

The patch is internal only at this moment, but I can try to get it public during this week maybe. Not sure though if I should merge it with the PR or keep it separate, cause it might indeed solve both live and event-live.

General note the seek(0) questions: I don't think this is spec specific, but simply how seeking in HLS Live in master/dev is currently implemented. Take a look here

https://github.com/google/ExoPlayer/blob/master/library/src/main/java/com/google/android/exoplayer/hls/HlsChunkSource.java#L281

and you will see that in case of a live stream, any seek operation will jump to the current live edge. NOTE that this did change in this PR and you will need to seek to the end of the seek range as reported by the events.

@ojw28

<h1>Rationale:</h1> This commit attempts to resolve the following issues: - get the key changes required to support Live/DVR merged to master by separating them from changes supporting Live/EVENT (PR#848) in the hope that smaller is better in the eyes of the maintainers, - address an @ojw28 concern that the Demo app not be made more complicated with additional features, - the PR comment from @fredx21 that the Live/DVR demo has issues with the seek bar behavior: to fix this requires a more robust Demo app. <h1>Changes to be committed:</h1> demo/src/main/java/com/google/android/exoplayer/demo/Samples.java demo/src/main/java/com/google/android/exoplayer/demo/player/DemoPlayer.java demo/src/main/java/com/google/android/exoplayer/demo/player/HlsRendererBuilder.java library/src/main/java/com/google/android/exoplayer/util/PlayerControl.java - Revert PR google#848 changes. library/src/main/java/com/google/android/exoplayer/hls/HlsChunkSource.java - Prune out PR google#848 changes and ensure that seeking cannot enter the region beyond the live edge (the last three segments in the media playlist).

jonasevcik · 2016-08-05T08:51:13Z

Hi @ojw28 I've written this for dev-v2 in much simpler fashion - no new entities, nor listeners. You can see the changes here: https://github.com/google/ExoPlayer/compare/dev-v2...jonasevcik:startover?expand=1
If it's ok with you, I can create a pull request.

jglanfield · 2016-10-14T19:12:04Z

No updates on this?

thasso added 2 commits October 7, 2015 12:39

Parse the EXT-X-PLAYLIST-TYPE tag and extract information about live …

11767b9

…events

Added support for HLS Live Events and expose seek-range change events

d17ba51

ojw28 force-pushed the dev branch from 8733eb8 to 6fb5052 Compare October 26, 2015 15:54

thasso added 2 commits October 27, 2015 15:22

Added event listener when creating the HLSChunkSource

c64a1cf

Delegate seek range changes to the PlayerControl and use them to

36f7f7e

configure the seekbar

googlebot added the cla: yes label Oct 28, 2015

pajatopmr reviewed Oct 29, 2015
View reviewed changes

pajatopmr mentioned this pull request Nov 6, 2015

The role of SeekMap #932

Closed

pajatopmr mentioned this pull request Nov 10, 2015

Design problem with seeking to live edge #946

Closed

ojw28 closed this Jul 28, 2016

google locked and limited conversation to collaborators Jun 28, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HLS Support for Live Events #848

HLS Support for Live Events #848

thasso commented Oct 7, 2015

thasso commented Oct 22, 2015

ojw28 commented Oct 26, 2015

pajatopmr commented Oct 26, 2015

ojw28 commented Oct 26, 2015

thasso commented Oct 27, 2015

pajatopmr commented Oct 28, 2015

thasso commented Oct 28, 2015

pajatopmr commented Oct 28, 2015

thasso commented Oct 29, 2015

pajatopmr commented Oct 29, 2015

pajatopmr Oct 29, 2015

pajatopmr Oct 29, 2015

ckarthikv commented Nov 8, 2015

pajatopmr commented Nov 9, 2015

ckarthikv commented Nov 9, 2015

thasso commented Nov 9, 2015

ckarthikv commented Nov 9, 2015

pajatopmr commented Nov 9, 2015

thasso commented Nov 9, 2015

jonasevcik commented Aug 5, 2016

jglanfield commented Oct 14, 2016

HLS Support for Live Events #848

HLS Support for Live Events #848

Conversation

thasso commented Oct 7, 2015

thasso commented Oct 22, 2015

ojw28 commented Oct 26, 2015

pajatopmr commented Oct 26, 2015

ojw28 commented Oct 26, 2015

thasso commented Oct 27, 2015

pajatopmr commented Oct 28, 2015

thasso commented Oct 28, 2015

pajatopmr commented Oct 28, 2015

thasso commented Oct 29, 2015

pajatopmr commented Oct 29, 2015

pajatopmr Oct 29, 2015

Choose a reason for hiding this comment

pajatopmr Oct 29, 2015

Choose a reason for hiding this comment

ckarthikv commented Nov 8, 2015

pajatopmr commented Nov 9, 2015

ckarthikv commented Nov 9, 2015

thasso commented Nov 9, 2015

ckarthikv commented Nov 9, 2015

pajatopmr commented Nov 9, 2015

thasso commented Nov 9, 2015

jonasevcik commented Aug 5, 2016

jglanfield commented Oct 14, 2016