Throw exception for timestamp issues that would stall playback #7029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis time limits the build for opensource. So just build core and hls (the two libraies TiVo is contributing to).
If the ExoPlayer encouters an unreported PTS discontinuity in the media that exceeds segment size the player will ultimately freeze forever (with one of the renderers starved for samples in the buffering state, even though LoadControl reports fully bufferd). This change detects the issue and fails the segment load. Note, other players (ffplay, Apple's AVPlayer, etc) 'recover' from these streams, at least playing the stream perphaps with A/V sync issues. These kind of stream issues regulary occur in broadcast streams where affiliate perform ad insertion on the fly.
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
Closed, will re-open without polluting commits |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExoPlayer can hang forever when presented with content with unmarked discontinuities. This change causes a playback error instead, reporting the errant segment[s].
Note, recovery would of course be the preferred course of action, hopefully this pull request can server as a place for discussing what that might look like.