Added mp3 support to FLV extractor #2683
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
tylerjroach
force-pushed
the
dev-v2
branch
2 times, most recently
from
84b20d4
to
59c44af
Compare
|
CLAs look good, thanks! |
| if (audioFormat == AUDIO_FORMAT_ALAW || audioFormat == AUDIO_FORMAT_ULAW) { | ||
| if (audioFormat == AUDIO_FORMAT_MP3) { | ||
| int sampleRateIndex = (header >> 2) & 0x03; | ||
| if (sampleRateIndex < 0 || sampleRateIndex >= AUDIO_SAMPLING_RATE_TABLE.length) { |
There was a problem hiding this comment.
This looks like it's impossible. Given L68, sampleRateIndex can only be 0,1,2 or 3 here, I think? If you agree, please delete this block (and the TAG constant near the top).
…s constrained to be between 0 and 3.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
I consent to my commits being used. |
MP3 support has been added to the flv extractor. This will be more important if #2590 or #2503 is accepted for rtmp streams with mp3 audio. This commit will add mp3 audio support to both of those pull requests as well as standard flv playback.