Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash after trying to play FLV on r2.0.1 #1899

Closed
mvasilchuk opened this issue Oct 5, 2016 · 2 comments
Closed

Crash after trying to play FLV on r2.0.1 #1899

mvasilchuk opened this issue Oct 5, 2016 · 2 comments
Labels
bug

Comments

@mvasilchuk
Copy link

Got a crash after trying to play one flv stream on Nexus 7 (2013):

java.lang.NullPointerException: Attempt to read from null array
at com.google.android.exoplayer2.source.ExtractorMediaPeriod.configureRetry(ExtractorMediaPeriod.java:460)
at com.google.android.exoplayer2.source.ExtractorMediaPeriod.onLoadError(ExtractorMediaPeriod.java:352)
at com.google.android.exoplayer2.source.ExtractorMediaPeriod.onLoadError(ExtractorMediaPeriod.java:49)
 at com.google.android.exoplayer2.upstream.Loader$LoadTask.handleMessage(Loader.java:359)
 at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:148)
 at android.os.HandlerThread.run(HandlerThread.java:61)
at com.google.android.exoplayer2.util.PriorityHandlerThread.run(PriorityHandlerThread.java:40)

Example stream: http://webtv.net.ua:8080/stream.flv

This stream cannot be played by r1.5.11 either (got error "Audio format not supported: 2") but at least it doesn't crash.
@ojw28 ojw28 added the bug label Oct 5, 2016
@ojw28
Copy link
Contributor

ojw28 commented Oct 5, 2016

We'll fix the crash (thanks!), but we wont be adding support for streams of this type (FLV containing MP3 and H263). We would accept a high quality pull request to add support, if someone external feels like spending time on it. We only support FLV at all due to an external contribution, and that contribution only supported FLV containing AAC and H264.

ojw28 added a commit that referenced this issue Oct 5, 2016
@ojw28
Fix retry crash in edge case
89c4380 
Configuration of retry currently fails if all of the
following are true, which is highly unlikely but does
occur in the ref'd issue.

1. Loading/extraction fails
2. Neither length of stream of a seek map is known
3. At least one track has been output by the extractor

Issue: #1899

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135228687
@ojw28
Copy link
Contributor

ojw28 commented Oct 5, 2016

Fixed to the extent it's going to be fixed. Feel free to send a pull request to add MP3 / H263 support in FLV if you feel motivated enough to create one!

@ojw28 ojw28 closed this as completed Oct 5, 2016
@google google locked and limited conversation to collaborators Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mvasilchuk @ojw28