Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTSP UDP->TCP failover inconsistency #11069

Closed
Docteh opened this issue Mar 16, 2023 · 1 comment
Closed

RTSP UDP->TCP failover inconsistency #11069

Docteh opened this issue Mar 16, 2023 · 1 comment
Assignees
@microkatz
Labels
question

Comments

@Docteh
Copy link

Docteh commented Mar 16, 2023

Hi, this is related to #9884

ExoPlayer has a feature with RTSP that if a UDP stream isn't received within a few seconds, it'll try again with TCP (Good feature)

If the server tells ExoPlayer that a UDP stream isn't available, and "RTSP/1.0 461 Unsupported Transport", it will NOT try TCP

Where this becomes a problem: If WMPlayer connects to a server with UDP available, and it doesn't receive a stream within a few seconds, it doesn't failover to TCP

I can do a work-around to tell WMPlayer clients that UDP is unavailable as a transport based on the User-Agent, but this does leave ExoPlayer clients waiting a few more seconds for video to start.

  • VRChat
  • AVPro (video widget)
  • Windows Media API or ExoPlayer depending on platform

Is there a reason to not understand the "Unsupported Transport" response? I notice that a LibVLC supports this.
tianyif pushed a commit to androidx/media that referenced this issue Mar 31, 2023
@microkatz @tianyif
Retry RTSP Setup with TCP if response with UDP is UnsupportedTransport
ecf4d8b 
If RTSP Setup Request with UDP receives HTTP Error Status 461 UnsupportedTransport, then client will retry with TCP.

Issue: google/ExoPlayer#11069
PiperOrigin-RevId: 518807829
tianyif pushed a commit that referenced this issue Mar 31, 2023
@microkatz @tianyif
Retry RTSP Setup with TCP if response with UDP is UnsupportedTransport
bbd45c8 
If RTSP Setup Request with UDP receives HTTP Error Status 461 UnsupportedTransport, then client will retry with TCP.

Issue: #11069
PiperOrigin-RevId: 518807829
@microkatz
Copy link
Contributor

@Docteh

Thank you for reporting your issue! I added functionality to handle the 461 error code in bbd45c8. The fix has been pushed into the dev-v2 branch. Hopefully this fixes your problem!

rohitjoins pushed a commit to androidx/media that referenced this issue Apr 18, 2023
@microkatz @rohitjoins
Retry RTSP Setup with TCP if response with UDP is UnsupportedTransport
eea3703 
If RTSP Setup Request with UDP receives HTTP Error Status 461 UnsupportedTransport, then client will retry with TCP.

Issue: google/ExoPlayer#11069
PiperOrigin-RevId: 518807829
(cherry picked from commit ecf4d8b)
rohitjoins pushed a commit that referenced this issue Apr 18, 2023
@microkatz @rohitjoins
Retry RTSP Setup with TCP if response with UDP is UnsupportedTransport
9e2ad62 
If RTSP Setup Request with UDP receives HTTP Error Status 461 UnsupportedTransport, then client will retry with TCP.

Issue: #11069
PiperOrigin-RevId: 518807829
(cherry picked from commit bbd45c8)
@google google locked and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@microkatz microkatz

Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Docteh @microkatz