-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump version number #137
bump version number #137
Conversation
The failing tests here are what I was referring to over in #131 btw; I think the CI needs updating. |
yup. but updating CI is non-trivial since it has a lot of obsolete dependencies (not to mention python 3.6 itself). so we can either:
|
I think that's about right. I'm inclined toward the second option for now. It has been very cool to see how much usage torchsde has received downstream! Hopefully this suggests that someone will be willing to step up to the plate and do the work to update the CI. If anyone else comes across this and wants to do the work, go for it! I'm very happy to merge fixes. ( |
any easy way to refactor from torchsde to diffrax? Have you seen models like SD1.5/SD XL 1.0 using diffrax in any context? So I could see it and try to refactor in Automatic1111 sd webui? |
Great questions!
I find refactoring to be straightforward. As someone who already knows both frameworks: for a "serious" model like a u-net, transformer, diffusion, whatever, it usually takes me about a day. Everyone's settled on the same basic set of primitives: linear layers, conv layers, and so on.
I don't know of specifically a public SD implementation. It wouldn't be terribly hard, though, and we could definitely publicise that as an example if someone takes the time to implement it. As a reference point though, there is a concise (hopefully pedagogical) diffusion implementation here. |
as such, pretty much NO application can refactor to switch away from basically only realistic choice is if someone forks this repo and takes on maintaining it. |
Given the discussions here, I'll try my best to find a few hours this weekend to patch the issues here, if they have not been fixed by then. |
@vladmandic #140 was merged, so please rebase? :) |
done! |
great stuff - now only for |
Hurrah! I've just merged and done a push to PyPI. Lmk how things go. |
Thanks! @akx @vladmandic @patrick-kidger |
looks all good here! |
bumps version number of torchsde package so it can be used to create a new release and published to pypi.
see #131 for details