Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow souffle binary to be set with SOUFFLE_BIN environment variable. #447

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

bgogul
Copy link
Collaborator

@bgogul bgogul commented Mar 11, 2022

This allows bazel test to be hermetic. Further, we do not need to have souffle binary in the path anymore and it can be configured as needed.

This allows bazel test to be hermetic. Further, we do not need to have
souffle in the path anymore to run the translator.
@bgogul bgogul requested review from aferr and markww March 11, 2022 01:34
Copy link
Collaborator

@aferr aferr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Maybe this also makes it easier to keep the build for binary transparency stuff hermetic as well.

@bgogul bgogul merged commit 1f670d1 into main Mar 14, 2022
@bgogul bgogul deleted the pass_souffle_bin@bgogul branch March 14, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants