Skip to content
This repository has been archived by the owner on Aug 31, 2022. It is now read-only.

Input Convex Neural Network Architecture and Tests #15

Merged
merged 10 commits into from
Nov 22, 2021
Merged

Input Convex Neural Network Architecture and Tests #15

merged 10 commits into from
Nov 22, 2021

Conversation

bunnech
Copy link
Contributor

@bunnech bunnech commented Nov 15, 2021

Adding input convex neural network architecture based on [1] and corresponding tests.

[1] Amos, Brandon, Lei Xu, and J. Zico Kolter. "Input Convex Neural Networks." International Conference on Machine Learning. PMLR, 2017.

@google-cla google-cla bot added the cla: no label Nov 15, 2021
@marcocuturi
Copy link
Contributor

Thanks Charlotte! I think you need to sign a CLA so that we can merge.

Copy link
Contributor

@marcocuturi marcocuturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Charlotte! before pushing I'd like to make sure we include the flax dependency in the project.

ott/core/nn_potentials/icnn.py Outdated Show resolved Hide resolved
ott/core/nn_potentials/icnn.py Outdated Show resolved Hide resolved
ott/core/nn_potentials/icnn.py Outdated Show resolved Hide resolved
ott/core/nn_potentials/icnn.py Outdated Show resolved Hide resolved
tests/core/icnns_test.py Outdated Show resolved Hide resolved
@bunnech
Copy link
Contributor Author

bunnech commented Nov 17, 2021

Thanks Charlotte! I think you need to sign a CLA so that we can merge.

Oh, yes. I signed the CLA.

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 18, 2021
Copy link
Contributor

@marcocuturi marcocuturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Charlotte

Copy link
Contributor

@marcocuturi marcocuturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Charlotte! It's great to have this ICNN interface!

ott/core/icnn.py Outdated Show resolved Hide resolved
Copy link
Contributor

@marcocuturi marcocuturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you clean up the utf 8?

marcocuturi
marcocuturi previously approved these changes Nov 22, 2021
Copy link
Contributor

@marcocuturi marcocuturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thks!

@marcocuturi marcocuturi dismissed their stale review November 22, 2021 18:26

Issue with internal change on google side.

Copy link
Contributor

@marcocuturi marcocuturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marcocuturi marcocuturi merged commit cdbde04 into google-research:master Nov 22, 2021
marcocuturi pushed a commit that referenced this pull request Nov 22, 2021
PiperOrigin-RevId: 411598206
@bunnech bunnech deleted the icnns branch November 22, 2021 19:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants