-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows for Building Models With Only First Party Data #480
Merged
blackwire
merged 24 commits into
google-marketing-solutions:master
from
blackwire:1pd-only-models
Nov 6, 2023
Merged
Allows for Building Models With Only First Party Data #480
blackwire
merged 24 commits into
google-marketing-solutions:master
from
blackwire:1pd-only-models
Nov 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves a few minor SQL issues. Adds GCLID requirement for Google Ads destination in the variable validator.
Adds unique_id booleans to top level for consistency. Updates test cases to check for user/client id.
Resolves a few issues with SQL when using only first party data.
Timespan in a table that only has one row per user is meaningless.
Adds 1 day limitation to the 1PD used in the output. Updates test cases to reflect changes. Adds requirement for trigger date if using 1PD only.
…tring comparison.
…te to work for all steps in the pipeline.
… 1PD only and google analytics output channel.
jmistral-google
requested changes
Nov 3, 2023
jmistral-google
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior there was a limitation that GA4 data was necessary to build the model. This update allows for the buildout of models using only first party data that is in BigQuery. Letting you select the necessary model parameters all from your first party data table.