Skip to content

Commit

Permalink
Update README and CI to use latest version (#289)
Browse files Browse the repository at this point in the history
  • Loading branch information
sethvargo authored Dec 13, 2023
1 parent 0ee75ee commit 1111597
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 31 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- name: 'npm build'
run: 'npm ci && npm run build'

- uses: 'google-github-actions/auth@main'
- uses: 'google-github-actions/auth@v2'
with:
workload_identity_provider: '${{ vars.WIF_PROVIDER_NAME }}'
service_account: '${{ vars.SERVICE_ACCOUNT_EMAIL }}'
Expand Down Expand Up @@ -62,7 +62,7 @@ jobs:
- name: 'npm build'
run: 'npm ci && npm run build'

- uses: 'google-github-actions/auth@main'
- uses: 'google-github-actions/auth@v2'
with:
workload_identity_provider: '${{ vars.WIF_PROVIDER_NAME }}'
service_account: '${{ vars.SERVICE_ACCOUNT_EMAIL }}'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
if: ${{ matrix.os == 'ubuntu-latest' }}
run: 'npm run lint'

- uses: 'google-github-actions/auth@main'
- uses: 'google-github-actions/auth@v2'
with:
workload_identity_provider: '${{ vars.WIF_PROVIDER_NAME }}'
service_account: '${{ vars.SERVICE_ACCOUNT_EMAIL }}'
Expand Down
36 changes: 8 additions & 28 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,13 @@ jobs:
steps:
- id: 'auth'
uses: 'google-github-actions/auth@v1'
uses: 'google-github-actions/auth@v2'
with:
workload_identity_provider: 'projects/123456789/locations/global/workloadIdentityPools/my-pool/providers/my-provider'
service_account: '[email protected]'
- id: 'get-credentials'
uses: 'google-github-actions/get-gke-credentials@v1'
uses: 'google-github-actions/get-gke-credentials@v2'
with:
cluster_name: 'my-cluster'
location: 'us-central1-a'
Expand Down Expand Up @@ -134,13 +134,13 @@ jobs:

steps:
- id: 'auth'
uses: 'google-github-actions/auth@v1'
uses: 'google-github-actions/auth@v2'
with:
workload_identity_provider: 'projects/123456789/locations/global/workloadIdentityPools/my-pool/providers/my-provider'
service_account: '[email protected]'

- id: 'get-credentials'
uses: 'google-github-actions/get-gke-credentials@v1'
uses: 'google-github-actions/get-gke-credentials@v2'
with:
cluster_name: 'my-cluster'
location: 'us-central1-a'
Expand All @@ -153,12 +153,12 @@ jobs:
job_id:
steps:
- id: 'auth'
uses: 'google-github-actions/auth@v1'
uses: 'google-github-actions/auth@v2'
with:
credentials_json: '${{ secrets.gcp_credentials }}'

- id: 'get-credentials'
uses: 'google-github-actions/get-gke-credentials@v1'
uses: 'google-github-actions/get-gke-credentials@v2'
with:
cluster_name: 'my-cluster'
location: 'us-central1-a'
Expand All @@ -176,7 +176,7 @@ jobs:
job_id:
steps:
- id: 'get-credentials'
uses: 'google-github-actions/get-gke-credentials@v1'
uses: 'google-github-actions/get-gke-credentials@v2'
with:
cluster_name: 'my-cluster'
location: 'us-central1-a'
Expand All @@ -196,7 +196,7 @@ jobs:
job_id:
steps:
- id: 'get-credentials'
uses: 'google-github-actions/get-gke-credentials@v1'
uses: 'google-github-actions/get-gke-credentials@v2'
with:
cluster_name: 'my-private-cluster'
location: 'us-central1-a'
Expand All @@ -206,26 +206,6 @@ jobs:
Follow the [Connect gateway documentation][connect-gw] for initial setup.
Note: The Connect Agent service account must have the correct [impersonation policy][connect-gw-impersonation] on the service account used to authenticate this action.
## Versioning
We recommend pinning to the latest available major version:
```yaml
- uses: 'google-github-actions/get-gke-credentials@v1'
```
While this action attempts to follow semantic versioning, but we're ultimately
human and sometimes make mistakes. To prevent accidental breaking changes, you
can also pin to a specific version:
```yaml
- uses: 'google-github-actions/[email protected]'
```
However, you will not get automatic security updates or new features without
explicitly updating your version number. Note that we only publish `MAJOR` and
`MAJOR.MINOR.PATCH` versions. There is **not** a floating alias for
`MAJOR.MINOR`.
[gke]: https://cloud.google.com/kubernetes-engine
[gcp-auth-plugin]: https://github.com/kubernetes/client-go/tree/master/plugin/pkg/client/auth/gcp
Expand Down

0 comments on commit 1111597

Please sign in to comment.