Skip to content

Commit

Permalink
Note .dockerignore in the exclusion for credentials
Browse files Browse the repository at this point in the history
The README indicates that the ghe-* files should be
excluded from git via the .gitignore file. However, from CI, it 
is less likely that users will create a new patch back to their version control with the results of their build, but it is more likely that they'll pack it into a container.

This commit clarifies that the container is an equal (or
larger) risk and should be excluded. This also works (for example) with Podman.

See:
1. https://docs.docker.com/engine/reference/builder/


 

Signed-off-by: Andrew Howden <[email protected]>
  • Loading branch information
andrewhowdencom authored Jan 4, 2024
1 parent 56562dd commit 3edf039
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ support](https://cloud.google.com/support).**
unable to authenticate.

- To create binaries, containers, pull requests, or other releases, add the
following to your `.gitignore` to prevent accidentially committing
credentials to your release artifact:
following to your `.gitignore`, `.dockerignore` or similar to prevent
accidentally committing credentials to your release artifact:

```text
# Ignore generated credentials from google-github-actions/auth
Expand Down

0 comments on commit 3edf039

Please sign in to comment.