-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more properties to errors and export errors. #112
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DellaBitta
reviewed
Apr 26, 2024
packages/main/src/errors.ts
Outdated
@@ -31,3 +40,30 @@ export class GoogleGenerativeAIResponseError< | |||
super(message); | |||
} | |||
} | |||
|
|||
/** | |||
* Error class covering http errors when calling the server. Includes http |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We seem to capitalize http
in our Firebase JS SDK's docs:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed.
dlarocque
approved these changes
Apr 29, 2024
DellaBitta
approved these changes
Apr 29, 2024
This was referenced May 30, 2024
This was referenced Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82
Creates a new
GoogleGenerativeAIFetchError
that extendsGoogleGenerativeAIError
with additional properties:status
- http status codestatusText
- http status texterrorDetails
- if the error response contained a json with anerror.details
field, which may include fields such as type and reasonExport all error classes.