Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Schema.number and Schema.integer factories ignoring format field #164

Merged
merged 2 commits into from
May 16, 2024
Merged

Fix Schema.number and Schema.integer factories ignoring format field #164

merged 2 commits into from
May 16, 2024

Conversation

davidmigloz
Copy link
Contributor

@davidmigloz davidmigloz commented May 14, 2024 •
edited
Loading

The format field was being ignored when using Schema.numberor Schema.integer factories.

@davidmigloz davidmigloz changed the title Fix Schema.number factory ignoring format field Fix Schema.number and Schema.integer factories ignoring format field May 14, 2024
@natebosch natebosch self-requested a review May 14, 2024 17:52
@natebosch natebosch merged commit c2c968a into google-gemini:main May 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebosch natebosch natebosch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidmigloz @natebosch