Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caution note to READMEs #133

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Add caution note to READMEs #133

merged 1 commit into from
Apr 26, 2024

Conversation

natebosch
Copy link
Collaborator

Add a note warning against leaking API keys with billing enabled in
client side applications.
Add to both the top-level README for this repository, as well as the
README published with the package and rendered on the pub site.

Drop -wip suffix from version to prepare for publish.

Add a note warning against leaking API keys with billing enabled in
client side applications.
Add to both the top-level README for this repository, as well as the
README published with the package and rendered on the pub site.

Drop `-wip` suffix from version to prepare for publish.
@natebosch natebosch requested a review from devoncarew April 26, 2024 20:30
Copy link
Collaborator

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

+1 to replicating the message in both the repo readme and the package's readme

@natebosch natebosch merged commit c8ad2ea into main Apr 26, 2024
7 checks passed
@natebosch natebosch deleted the key-leak-warning branch April 26, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants