Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added system instruction support. #117

Closed
wants to merge 1 commit into from
Closed

Conversation

kddlb
Copy link

@kddlb kddlb commented Apr 9, 2024

I'm not sure if it's up to Google's coding standards.

@devoncarew
Copy link
Collaborator

Interesting; I found some docs for this feature here: https://ai.google.dev/docs/system_instructions. Do you have any links to API docs for how this is exposed in other sdks (Python, REST, ...)?

@devoncarew
Copy link
Collaborator

cc @natebosch

@natebosch
Copy link
Collaborator

Thanks for the PR!

There were a few changes we would have needed to make here, but I had a local branch with those changes almost all ready so I went ahead and pushed up that PR to shorten the cycle time. Primarily my version accepts Content? instead of String? to match the backend API a little more directly. In the Python SDK I think they tend to be a little looser with types and accept multiple formats. If we had union types or method overloads I'd probably do the same and accept either String or Content.

I'll close this PR for now and run with #119

@natebosch natebosch closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants