Add support for overriding API version #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API will be required for authors to use to try function calling while the backend support is still in version `v1beta`. Add a RequestOptions class. For now this supports only the `apiVersion` configuration. In the future this may add a `timeout` (#44) if implement a deeper HTTP timeout functionality than `Future.timeout`. Add a utility for VertexAI SDK to pass a callback instead of a single URI.
|
I had implemented this originally with the intent to support |
devoncarew
approved these changes
Apr 9, 2024
| required ApiClient client, | ||
| List<SafetySetting> safetySettings = const [], | ||
| GenerationConfig? generationConfig, | ||
| RequestOptions? requestOptions, |
There was a problem hiding this comment.
If we do think we'll have more options, this lgtm. Otherwise we may want to just simplify this to apiVersion.
There was a problem hiding this comment.
I do think it's likely we'll add more options at some point. I'm pretty comfortable starting with this design even if there is only a single configuration because it matches exactly the design in other languages (although some of the other languages already support timeout).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API will be required for authors to use to try function calling
while the backend support is still in version
v1beta.Add a RequestOptions class. For now this supports only the
apiVersionconfiguration. In the future this may add a
timeout(#44) if implementa deeper HTTP timeout functionality than
Future.timeout.