This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Fix memory leaks #110
Merged
Fix memory leaks #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without jQuery, velocity implements it's own .data() utilities which store element (animation) data in one big cache. Data in this cache is never cleared which is an issue because it keeps references to all animated dom elements as well as whole React trees through velocity-react's `complete` handler. This commit crudely clears the most important velocity data when an animated component is unmounted. See julianshapiro/velocity#644
|
Also, sorry for the lightning PR before any issue discussion. I just hammered this fix out because the issue is critical in our project. We're running on a fork so I'm happy to close this PR if you want to look into other solutions. |
|
👍 up |
|
Cool. This seems reasonable. I think this also safe server-side since Heads up, @kenwheeler, it might be nicer to have a Velocity helper for clearing this data rather than duplicating the |
|
I'd like to merge this, I just need to validate that it's also fine when jQuery is installed. |
|
Any news? |
|
Demo still seems to work with this, so I think it's safe. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without jQuery, velocity implements it's own
$.data()utility whichstores element (animation) data in one big cache object.
Data in this cache is never cleared which is an issue because it keeps
references to all animated dom elements as well as whole React trees
through velocity-react's
completehandler.This commit crudely clears the most important velocity data when an
animated component is unmounted.
See julianshapiro/velocity#644
Otherwise, this leak causes constant crashes for non-trivial webapps on mobile devices.