Preparation for OpenSpiel 1.5: Add support for Python 3.12. #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanctot
added
imported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not yet properly tested on Github Actions. Will wait to update this when Ubuntu 24.04 runner is available.
TODO and notes:
Add test for
macos-14runnerAdd test for
ubuntu-24.04runner (once it's available)Julia API not installing on Ubuntu 24.04. @findmyway: I will reach out with details and plan for a fix.
Disabled Python tests for now as they need to be ported to Keras 3:
algorithms/alpha_zero/model_test.pyalgorithms/deep_cfr_tf2_test.pyalgorithms/rcfr_test.py