Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back cvxopt to extra deps now that Python 3.11 wheels are available #1067

Merged
merged 3 commits into from
May 15, 2023

Conversation

lanctot
Copy link
Collaborator

@lanctot lanctot commented May 10, 2023

Ref: cvxopt/cvxopt#228.

@lanctot
Copy link
Collaborator Author

lanctot commented May 11, 2023

Hello @findmyway,

I am getting an odd error in Julia CxxWrap compilation seemingly unrelated to this change: https://github.com/deepmind/open_spiel/actions/runs/4941971630/jobs/8843020459

I tried rerunning the job twice and it still produces this same error.

Any ideas? Should I increase the version number of CxxWrap?

@findmyway
Copy link
Collaborator

[email protected] just got released yesterday. I guess CxxWrap is not updated corresponding yet.

As a temporary fix, we may need to set Julia version to 1.8 in the github action explicitly for now.

- uses: julia-actions/setup-julia@v1
  with:
    version: 1.8

Set wheels.yml to use Julia version 1.8
@lanctot lanctot merged commit db0f4a7 into master May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants