This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
Fix HanabiState.copy setting a bad pointer for _game member #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
HanabiState.fireworks()
returning incorrect data when called on a copied HanabiState object.Came across this bug in work-related project.
The bug is pretty easily fixed by retrieving the parent game of the state into an existing
pyhanabi_game_t*
instead of returning a void pointer as was done before.Steps to reproduce the bug as it existed:
HanabiState
object by callingHanabiState.copy
or using the copy constructor manuallyHanabiState._game
will receive ahanabi_learning_env::HanabiGame*
rather thanpyhanabi_game_t*
.HanabiState.fireworks()
and any derivedHanabiObservation.fireworks()
calls will return bad data, becauselib.NumPlayers
/lib.NumColors
/lib.NumRanks
will access garbage memory when called on the resulting_game
field.